Fix duplicate 'about' in report collection checkback message - #45108
Fix duplicate 'about' in report collection checkback message#45108kilo-code-bot[bot] wants to merge 1 commit into
Conversation
The formatDistance() function from date-fns already prefixes its output with 'about' for approximate durations (e.g. 'about 23 hours'). The template string also included 'about', producing 'about about 23 hours'. Remove the redundant 'about' from the template.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #45108 +/- ##
========================================
Coverage 66.82% 66.82%
========================================
Files 2720 2720
Lines 218985 218985
Branches 10709 10583 -126
========================================
Hits 146333 146333
Misses 59492 59492
Partials 13160 13160
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| <> | ||
| Fleet is collecting report results. <br /> | ||
| Check back in about {readableCheckbackTime}. | ||
| Check back in {readableCheckbackTime}. |
There was a problem hiding this comment.
Why? readableCheckbackTime already includes "about": https://github.com/date-fns/date-fns/blob/dd66398305c2b015fba3c1b3d31ccff42ee8d4cf/src/formatDistance/index.ts#L31-L49
There was a problem hiding this comment.
Will move this into a bug report so it can get merged faster. Ty @MikeWilkes-Aikido!
|
@RachelElysia maybe we clean this up for Mike and get it merged? Coverting to draft until we tackle it |
|
I probably should have just filed a bug. Will do. |
3 participants
Summary
NoResults.tsxformatDistance()function from date-fns already includes "about" in its output (e.g., "about 23 hours"), so the template was producing "Check back in about about 23 hours"Changes
frontend/pages/queries/details/components/NoResults/NoResults.tsx— removed the extra "about " prefix from the template string on the checkback time message.Built for Mike McNeil by Kilo for Slack